net: stmmac: dwmac-qcom-ethqos: Restore nominal clk_ptp_ref frequency by pkrian · Pull Request #619 · qualcomm-linux/kernel

pkrian · 2026-05-27T09:24:40Z

The current implementation configures the PTP reference clock (clk_ptp_ref) to its maximum supported frequency in order to improve timestamp resolution.

While higher clock rates benefit PTP/gPTP accuracy, forcing the PTP reference clock to operate at maximum frequency results in increased power consumption, as the clock remains at this rate irrespective of actual runtime requirements.

On power-sensitive platforms and in use cases where ultra-high timestamp precision is not required, this leads to unnecessary power overhead.

Update the driver to restore the nominal/default clock configuration for clk_ptp_ref, allowing the platform to operate at its baseline frequency (e.g., ~19.2 MHz). This reduces power consumption while maintaining functional correctness for standard PTP operation.

Higher clock frequencies can be enabled through targeted configuration if improved timestamp resolution is required for specific applications

qswat-orbit-external · 2026-06-01T05:59:09Z

Merge Check Failed: No CR Numbers Found

Error: No Change Request numbers were found.

Please add Change Request numbers to your pull request description in the format CRs-Fixed: 12345 or link GitHub issues that are associated with Change Requests.

qlijarvis · 2026-06-01T06:44:22Z

PR #619 — validate-patch

PR: #619

Verdict	Issues	Detailed Report
❌	0	Full report

Final Summary

Lore link present: No — no lore.kernel.org link found in commit message or PR description
Lore link matches PR commits: N/A — no lore link to compare against
Upstream patch status: Unknown — cannot determine without lore link or vendor prefix
PR present in qcom-next: Not checked — validation blocked by missing upstream reference

Verdict: ❌ — click to expand

Patch Validation Report

PR: #619 - net: stmmac: dwmac-qcom-ethqos: Restore nominal clk_ptp_ref frequency
Upstream: (none found)
Verdict: ❌ FAIL

Reason

No lore.kernel.org link was found in the PR description or commit message.
This skill only validates patches against a lore.kernel.org source.

The commit message lacks:

Any lore.kernel.org URL (Link:, Patch-mainline:, or inline reference)

Vendor prefix (UPSTREAM:, FROMLIST:, BACKPORT:, QCLINUX:, PENDING:, WORKAROUND:)

Signed-off-by trailer

Fixes: tag (if this addresses a bug)

Commit Message

Check Status Note

Subject matches upstream ⏭️ N/A No upstream link to compare

Body preserves rationale ⏭️ N/A No upstream link to compare

Fixes tag present/correct ❌ Missing (if this fixes a bug/regression)

Authorship preserved ⏭️ N/A No upstream link to compare

Backport note (if applicable) ⏭️ N/A No upstream link to compare

Signed-off-by present ❌ Missing

Diff

File Status Notes

drivers/net/ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c ⏭️ Removes ethqos_ptp_clk_freq_config function (18 lines deleted) — cannot validate without upstream reference

Issues

Missing lore link: No Link: https://lore.kernel.org/... tag in commit message

Missing vendor prefix: Commit subject has no prefix (UPSTREAM:/FROMLIST:/BACKPORT:/QCLINUX:/etc.)

Missing Signed-off-by: No DCO sign-off present

Missing Fixes tag: If this addresses a regression or bug, a Fixes: tag should reference the commit that introduced the issue

Recommendation

Cannot validate without upstream reference. Before merging, the commit must be updated with one of:

If this is an upstream patch (posted to netdev@vger.kernel.org or already merged):

Add prefix: UPSTREAM: (if merged) or FROMLIST: (if posted but not merged)

Add Link: https://lore.kernel.org/r/<message-id> to commit message

Add Signed-off-by: Kiran Patchala <pkiran@qti.qualcomm.com>

Re-run validation

If this is a vendor-specific change (not intended for upstream):

Add prefix: QCLINUX: net: stmmac: dwmac-qcom-ethqos: Restore nominal clk_ptp_ref frequency

Add Signed-off-by: Kiran Patchala <pkiran@qti.qualcomm.com>

Add rationale for why this is vendor-only (e.g., "Qualcomm-specific power optimization")

If this reverts a previous commit:

Use Revert "..." format in subject

Add prefix before Revert (e.g., QCLINUX: Revert "...")

Reference the commit being reverted

Verdict

❌ FAIL — Missing mandatory upstream reference or vendor prefix. Commit cannot be validated or merged in current form.

Final Summary

Lore link present: No — no lore.kernel.org link found in commit message or PR description

Lore link matches PR commits: N/A — no lore link to compare against

Upstream patch status: Unknown — cannot determine without lore link or vendor prefix

PR present in qcom-next: Not checked — validation blocked by missing upstream reference

qlijarvis · 2026-06-01T06:44:24Z

PR #619 — checker-log-analyzer

PR: #619
Checker run: https://github.com/qualcomm-linux/kernel-config/actions/runs/26738012487

Checker	Result	Summary
Checker	Result	Summary
checkpatch	❌	Missing Signed-off-by line
dt-binding-check	⏭️	No DT binding changes
dtb-check	⏭️	No devicetree changes
sparse-check	✅	Passed
check-uapi-headers	✅	No UAPI changes
check-patch-compliance	❌	Missing required subject prefix
tag-check	❌	Missing required subject prefix (if not targeting qcom-next/qcom-next-staging)

Detailed report: Full report

Checker analysis — click to expand

🤖 CI Checker Analysis (checker-log-analyzer)

PR: #619 - net: stmmac: dwmac-qcom-ethqos: Restore nominal clk_ptp_ref frequency
Source: https://github.com/qualcomm-linux/kernel-config/actions/runs/26738012487

Checker Result Summary

checkpatch ❌ Missing Signed-off-by line

dt-binding-check ⏭️ No DT binding changes

dtb-check ⏭️ No devicetree changes

sparse-check ✅ Passed

check-uapi-headers ✅ No UAPI changes

check-patch-compliance ❌ Missing required subject prefix

tag-check ❌ Missing required subject prefix (if not targeting qcom-next/qcom-next-staging)

❌ checkpatch

Root cause: Commit 76bac09 is missing the mandatory Signed-off-by: line.

Failure details:
ERROR: Missing Signed-off-by: line(s)

76bac092b9f0c18c8f79e879dd2c0fb8e8d147c2 total: 1 errors, 0 warnings, 0 checks, 30 lines checked

Commit 76bac092b9f0 ("net: stmmac: dwmac-qcom-ethqos: Restore nominal clk_ptp_ref frequency") has style problems, please review.
Fix: Add the Signed-off-by: line to the commit message:
git rebase -i a1f6d71a69b09d36f9af071759877e6d33b572fa
# Mark commit 76bac092b9f0 as 'edit'
git commit --amend --signoff --no-edit
git rebase --continue
Reproduce locally:
./scripts/checkpatch.pl --strict --ignore FILE_PATH_CHANGES --git a1f6d71a69b09d36f9af071759877e6d33b572fa..76bac092b9f0c18c8f79e879dd2c0fb8e8d147c2
❌ check-patch-compliance

Root cause: Commit subject does not start with a required prefix (FROMLIST:, FROMGIT:, UPSTREAM:, or BACKPORT:).

Failure details:
Checking commit: net: stmmac: dwmac-qcom-ethqos: Restore nominal clk_ptp_ref frequency
Commit summary does not start with a required prefix
Fix: The commit subject must start with one of the allowed prefixes. Based on the nature of this change (power optimization for Qualcomm platform), choose the appropriate prefix:

If this patch has been posted to the upstream mailing list (netdev/lkml), use FROMLIST: and add a Link: tag pointing to the lore.kernel.org URL

If this patch is already merged upstream, use UPSTREAM: and add a Link: tag

If this is a vendor-specific change with no upstream equivalent, use QCLINUX: (note: this will still fail check-patch-compliance, which is a known limitation)

Example fix for a posted patch:
git rebase -i a1f6d71a69b09d36f9af071759877e6d33b572fa
# Mark commit as 'edit'
git commit --amend -m "FROMLIST: net: stmmac: dwmac-qcom-ethqos: Restore nominal clk_ptp_ref frequency

<original commit body>

Link: https://lore.kernel.org/...
Signed-off-by: Kiran Patchala <pkiran@qti.qualcomm.com>"
git rebase --continue
❌ tag-check

Root cause: Subject line does not start with a required prefix tag.

Applies when: The PR target branch is not qcom-next or qcom-next-staging.

Note: Unable to determine the target branch from available logs. If this PR targets any branch other than qcom-next or qcom-next-staging, the subject prefix is mandatory.

Failure details:
Commit 76bac092b9f0 ("net: stmmac: dwmac-qcom-ethqos: Restore nominal clk_ptp_ref frequency")
Subject line does not start with a required prefix.
Required prefixes: FROMLIST:, FROMGIT:, UPSTREAM:, BACKPORT:, QCLINUX:, PENDING:, WORKAROUND:

Fix: Same as check-patch-compliance fix above. Add the appropriate prefix based on the patch origin.

Verdict

2-3 blockers must be fixed before merge:

Critical: Add Signed-off-by: line (checkpatch ERROR)

Critical: Add required subject prefix (check-patch-compliance + tag-check)

Recommended: Add Link: tag if the patch has an upstream reference

The code change itself is clean (no sparse issues, no DT/UAPI changes). Once the commit metadata is corrected, this should be ready to merge.

shashim-quic

submit patch upstream and bring it as FROMLIST.

pkrian · 2026-06-09T09:36:25Z

qli-2.0 GA Critical Fix

shashim-quic

Please send the patch upstream and bring as FROMLIST.

sgaud-quic · 2026-06-10T04:27:35Z

checkpatch | ❌ | Missing Signed-off-by line

Committer sign-off is missing

qswat-orbit-external · 2026-06-10T10:29:37Z

Merge Check Failed: No CR Numbers Found

Error: No Change Request numbers were found.

Please add Change Request numbers to your pull request description in the format CRs-Fixed: 12345 or link GitHub issues that are associated with Change Requests.

pkrian · 2026-06-10T11:09:28Z

CRs-Fixed: 4549777

…_ref" This reverts commit db845b9. Reason: this change causes the PTP clock to always be in Turbo mode which can cause power KPI regression. Signed-off-by: Kiran Patchala <pkiran@qti.qualcomm.com>

sgaud-quic · 2026-06-11T07:11:17Z

CRs-Fixed: 4549777

This should be added to PR Body
Please refer : https://qualcomm-confluence.atlassian.net/wiki/spaces/LK/pages/2849559462/QLI+Mainline+2.0+CR+Workflow

qcomlnxci · 2026-06-11T08:50:48Z

Test jobs on c939be9

qcomlnxci · 2026-06-11T08:50:52Z

Test Matrix

Test Case	lemans-evk	monaco-evk	qcs615-ride	qcs6490-rb3gen2	qcs8300-ride	qcs9100-ride-r3	x1e80100-crd
BT_FW_KMD_Service	◻️	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	◻️
BT_ON_OFF	◻️	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	◻️
BT_SCAN	◻️	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	◻️
CPUFreq_Validation	◻️	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	◻️
CPU_affinity	◻️	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	◻️
DSP_AudioPD	◻️	✅ Pass	⚠️ skip	✅ Pass	✅ Pass	⚠️ skip	◻️
Ethernet	◻️	✅ Pass	⚠️ skip	⚠️ skip	⚠️ skip	⚠️ skip	◻️
Freq_Scaling	◻️	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	◻️
GIC	◻️	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	◻️
IPA	◻️	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	◻️
Interrupts	◻️	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	◻️
OpenCV	◻️	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	◻️
PCIe	◻️	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	◻️
Probe_Failure_Check	◻️	❌ Fail	✅ Pass	❌ Fail	❌ Fail	❌ Fail	◻️
RMNET	◻️	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	◻️
UFS_Validation	◻️	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	◻️
USBHost	◻️	❌ Fail	❌ Fail	❌ Fail	❌ Fail	❌ Fail	◻️
WiFi_Firmware_Driver	◻️	❌ Fail	❌ Fail	✅ Pass	✅ Pass	✅ Pass	◻️
WiFi_OnOff	◻️	❌ Fail	⚠️ skip	✅ Pass	✅ Pass	✅ Pass	◻️
adsp_remoteproc	◻️	✅ Pass	✅ Pass	✅ Pass	✅ Pass	❌ Fail	◻️
cdsp_remoteproc	◻️	✅ Pass	✅ Pass	✅ Pass	✅ Pass	❌ Fail	◻️
gpdsp_remoteproc	◻️	✅ Pass	⚠️ skip	⚠️ skip	✅ Pass	❌ Fail	◻️
hotplug	◻️	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	◻️
irq	◻️	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	◻️
kaslr	◻️	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	◻️
pinctrl	◻️	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	◻️
qcom_hwrng	◻️	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	◻️
remoteproc	◻️	✅ Pass	✅ Pass	✅ Pass	✅ Pass	❌ Fail	◻️
rngtest	◻️	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	◻️
shmbridge	◻️	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	◻️
smmu	◻️	✅ Pass	❌ Fail	✅ Pass	✅ Pass	❌ Fail	◻️
watchdog	◻️	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	◻️
wpss_remoteproc	◻️	✅ Pass	⚠️ skip	✅ Pass	✅ Pass	✅ Pass	◻️

qcomlnxci · 2026-06-11T09:52:59Z

Test jobs on c939be9

qcomlnxci · 2026-06-11T09:53:01Z

Test Matrix

Test Case	lemans-evk	monaco-evk	qcs615-ride	qcs6490-rb3gen2	qcs8300-ride	qcs9100-ride-r3	x1e80100-crd
BT_FW_KMD_Service	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	◻️
BT_ON_OFF	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	◻️
BT_SCAN	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	◻️
CPUFreq_Validation	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	◻️
CPU_affinity	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	◻️
DSP_AudioPD	✅ Pass	✅ Pass	⚠️ skip	✅ Pass	✅ Pass	⚠️ skip	◻️
Ethernet	⚠️ skip	✅ Pass	⚠️ skip	⚠️ skip	⚠️ skip	⚠️ skip	◻️
Freq_Scaling	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	◻️
GIC	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	◻️
IPA	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	◻️
Interrupts	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	◻️
OpenCV	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	◻️
PCIe	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	◻️
Probe_Failure_Check	❌ Fail	❌ Fail	✅ Pass	❌ Fail	❌ Fail	❌ Fail	◻️
RMNET	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	◻️
UFS_Validation	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	◻️
USBHost	❌ Fail	❌ Fail	❌ Fail	❌ Fail	❌ Fail	❌ Fail	◻️
WiFi_Firmware_Driver	❌ Fail	❌ Fail	❌ Fail	✅ Pass	✅ Pass	✅ Pass	◻️
WiFi_OnOff	✅ Pass	❌ Fail	⚠️ skip	✅ Pass	✅ Pass	✅ Pass	◻️
adsp_remoteproc	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	❌ Fail	◻️
cdsp_remoteproc	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	❌ Fail	◻️
gpdsp_remoteproc	✅ Pass	✅ Pass	⚠️ skip	⚠️ skip	✅ Pass	❌ Fail	◻️
hotplug	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	◻️
irq	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	◻️
kaslr	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	◻️
pinctrl	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	◻️
qcom_hwrng	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	◻️
remoteproc	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	❌ Fail	◻️
rngtest	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	◻️
shmbridge	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	◻️
smmu	❌ Fail	✅ Pass	❌ Fail	✅ Pass	✅ Pass	❌ Fail	◻️
watchdog	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	◻️
wpss_remoteproc	✅ Pass	✅ Pass	⚠️ skip	✅ Pass	✅ Pass	✅ Pass	◻️

sgaud-quic · 2026-06-11T12:14:39Z

CRs-Fixed : to be added to PR Body

qswat-orbit-external · 2026-06-12T01:50:49Z

Merge Check Failed: No CR Numbers Found

Error: No Change Request numbers were found.

Please add Change Request numbers to your pull request description in the format CRs-Fixed: 12345 or link GitHub issues that are associated with Change Requests.

pkrian changed the base branch from main to qcom-6.18.y June 1, 2026 05:47

pkrian requested review from a team, quic-tingweiz, rrnayak and trsoni June 1, 2026 05:47

pkrian force-pushed the ptp_clk branch from 4de90ec to 76bac09 Compare June 1, 2026 05:59

shashim-quic requested changes Jun 1, 2026

View reviewed changes

sgaud-quic added this to the qli-2.0 GA pull-request freeze milestone Jun 9, 2026

shashim-quic requested changes Jun 10, 2026

View reviewed changes

pkrian force-pushed the ptp_clk branch from 76bac09 to a6864f6 Compare June 10, 2026 10:29

qcomlnxci requested a review from a team June 10, 2026 10:31

pkrian force-pushed the ptp_clk branch from a6864f6 to f2011a8 Compare June 11, 2026 06:37

Revert "net: stmmac: dwmac-qcom-ethqos: Use max frequency for clk_ptp…

c939be9

…_ref" This reverts commit db845b9. Reason: this change causes the PTP clock to always be in Turbo mode which can cause power KPI regression. Signed-off-by: Kiran Patchala <pkiran@qti.qualcomm.com>

pkrian force-pushed the ptp_clk branch from f2011a8 to c939be9 Compare June 11, 2026 07:03

shashim-quic approved these changes Jun 11, 2026

View reviewed changes

Conversation

pkrian commented May 27, 2026 • edited by sgaud-quic Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

qswat-orbit-external Bot commented Jun 1, 2026

Uh oh!

qlijarvis commented Jun 1, 2026

PR #619 — validate-patch

Final Summary

Patch Validation Report

Reason

Commit Message

Diff

Issues

Recommendation

Verdict

Final Summary

Uh oh!

qlijarvis commented Jun 1, 2026

PR #619 — checker-log-analyzer

🤖 CI Checker Analysis (checker-log-analyzer)

❌ checkpatch

❌ check-patch-compliance

❌ tag-check

Verdict

Uh oh!

shashim-quic left a comment

Choose a reason for hiding this comment

Uh oh!

pkrian commented Jun 9, 2026

Uh oh!

shashim-quic left a comment

Choose a reason for hiding this comment

Uh oh!

sgaud-quic commented Jun 10, 2026

Uh oh!

qswat-orbit-external Bot commented Jun 10, 2026

Uh oh!

pkrian commented Jun 10, 2026

Uh oh!

sgaud-quic commented Jun 11, 2026

Uh oh!

qcomlnxci commented Jun 11, 2026

Test jobs on c939be9

Uh oh!

qcomlnxci commented Jun 11, 2026

Test Matrix

Uh oh!

qcomlnxci commented Jun 11, 2026

Test jobs on c939be9

Uh oh!

qcomlnxci commented Jun 11, 2026

Test Matrix

Uh oh!

sgaud-quic commented Jun 11, 2026

Uh oh!

qswat-orbit-external Bot commented Jun 12, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

pkrian commented May 27, 2026 •

edited by sgaud-quic

Loading